Wrappers don't wrap everything what should be wrapped
(MAGNOLIA-4810)
|
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | 4.5 |
| Fix Version/s: | 4.5.8 |
| Type: | Sub-task | Priority: | Critical |
| Reporter: | Jan Haderka | Assignee: | Jan Haderka |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Description |
|
Those two wrappers are most often used and as such most critical. |
| Comments |
| Comment by Tobias Mattsson [ 25/Feb/13 ] |
|
I would prefer if the ContentDecorator classes for escaping and i18n were top level public classes to promote using them as:
new I18nContentDecorator().wrapNode(node)
This will add new constructors to HTMLEscapingNodeWrapper, HTMLEscapingPropertyWrapper and I18nNodeWrapper. The existing ones are kept but deprecated. I'm note so convinced we should deprecate ChildWrappingNodeWrapper, its still a viable option when the full decoration offered by ContentDecorator isn't necessary. |
| Comment by Jan Haderka [ 27/Feb/13 ] |
|
Fair enough, externalized the decorators. Also added some generics to it to make use easier. And exposed decorator in property wrapper (was already exposed in the node wrapper). |
| Comment by Jan Haderka [ 03/Mar/13 ] |
|
commits https://git.magnolia-cms.com/gitweb/?p=magnolia_main.git;a=commit;h=450295ad070e7560e8f0684256b1c7c48eb7391c and https://git.magnolia-cms.com/gitweb/?p=magnolia_main.git;a=commit;h=981acd7d9cda24069baaa6589ca50250d5bbd057 were accidentally made under |