[MAGNOLIA-490] make tree handlers independent of repositories Created: 20/Jul/05  Updated: 17/Mar/09  Resolved: 10/Aug/05

Status: Closed
Project: Magnolia
Component/s: templating
Affects Version/s: 2.1 Final
Fix Version/s: 2.1 Final

Type: Improvement Priority: Major
Reporter: Michael Aemisegger Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

all


Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

tree handlers should not be tied to a particular repository. I suggest to introduce a new request parameter 'mgnlTreeHandler' to be passed around where it is needed instead of using the request parameter 'repository' for identifying the tree handler.

This would make it possible to have different views on the same repository.



 Comments   
Comment by Michael Aemisegger [ 20/Jul/05 ]

ok, I just noticed

/**

  • Override this method if you are not using the same name for the tree and the repository
  • @return name of the repository
    */
    protected String getRepository() { return getName(); }

in AdminTreeMVCHandler.

So, the improvement would rather be to rename the misleading request parameter 'repository' to 'mgnlTreeHandler' to prevent misunderstandings.

I know, of course this has historical reason.

Comment by Philipp Bracher [ 20/Jul/05 ]

Overriding getRpository() leads to other problems inside the tree, but i will work on it very soon

Comment by Michael Aemisegger [ 20/Jul/05 ]

Tree.java:

getRepository() should be replaced by getName() in the method

getHtmlFooter():

html.append("var " //$NON-NLS-1$
+ this.getJavascriptTree() + "=new mgnlTree('" //$NON-NLS-1$
+ this.getName() + "','" //$NON-NLS-1$
+ this.getPath() + "','" //$NON-NLS-1$
+ this.getJavascriptTree() + "'," //$NON-NLS-1$
+ this.getHeight() + ");"); //$NON-NLS-1$

Because my code base is already quite different to the original, it would mean too much work for me to create patches, Sorry.

Comment by Philipp Bracher [ 05/Aug/05 ]

the tree name is not longer linked to the repository name. i had also to change the tree.js and andminCentral.js

Generated at Mon Feb 12 03:17:56 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.