[MAGNOLIA-4916] Add possibility to allow multiple wrapping Created: 21/Mar/13  Updated: 17/May/13  Resolved: 25/Mar/13

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 4.5.8
Fix Version/s: 4.5.9

Type: Bug Priority: Critical
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MAGNOLIA-4867 Throw IAE in DelegateNodeWrapper.setW... Closed
caused by MAGNOLIA-4873 Throw IAE in DelegateNodeWrapper.setW... Closed
duplicate
is duplicated by MAGNOLIA-4949 Extra area on Home template Closed
is duplicated by MAGNOLIA-5040 Inheritance: nested areas cannot be i... Closed
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

MAGNOLIA-4867 prohibited multiple wrapping for DelegateNodeWrapper, but:

  • Some of ContentDecorators may require multiple wrapping:
    • Add ContentDecorator.isMultipleWrapEnable() method.
    • Override ContentDecorator.setWrappedNode() and check if multiple wrapping is enabled. If so, don't check wrapping with this decorator.
  • InheritanceNodeWrapper and PropertyFilteringNodeWrapper have to allow multilevel inheritance.
    • Override its setWrappedNode() method to allow this
  • Forbid inheritance for JCRPropertiesFilteringNodeWrapper and JCRMgnlPropertiesFilteringNodeWrapper


 Comments   
Comment by Leo Lozes [ 30/Apr/13 ]

We just spent 6h of one of our developers because of this.
Since 4.5, every single update that we've deployed had errors, when before that they were usually butter smooth.
We are all developers, and I understand that Magnolia is a big project, and testing everything is difficult, but the home page of 80% of our websites is crashing with this, it's not a hidden bug.

Generated at Mon Feb 12 04:00:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.