[MAGNOLIA-4999] SessionUtil#getNode(String, String) should avoid internal PathNotFoundException Created: 29/Apr/13  Updated: 29/Apr/13  Resolved: 29/Apr/13

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 4.5.8, 5.0
Fix Version/s: 4.5.9

Type: Bug Priority: Neutral
Reporter: Daniel Lipp Assignee: Daniel Lipp
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
duplicate
is duplicated by MAGNOLIA-4995 Better handling of exceptions in Sess... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Iteration 2013-17

 Description   

SessionUtil#getNode(String, String) returns either the requested Node or null if not found. There can be various reasons why that Node could not be found. e.g. there could have been a technical problem accessing JCR. In that case logging that exception and returning null is fine.



 Comments   
Comment by Daniel Lipp [ 29/Apr/13 ]

Fix for 4.5 was accidentally included in 9ed0437119990e9d7201e75168d51862991ea498 (QA commit) already - hence there's not proper MAGNOLIA-4999 commit in 4.5.x branch.

Comment by Jan Haderka [ 29/Apr/13 ]

1) If you are making this method tolerant to the fact that someone calls it w/ none existent path, then do not log this at all. WARN message is no better then previous ERROR message.
2) The fix version should be only the earliest version on which it is fixed - 4.5.9. Otherwise it gives impression that issue was fixed in 4.5.9 and then reoccured later again and had to be refixed for 5.0 which is not the case.

Generated at Mon Feb 12 04:01:01 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.