[MAGNOLIA-500] DialogMVCHandler cannot handle arbitrary nodeCollections as target Created: 24/Jul/05  Updated: 17/Mar/09  Resolved: 26/Jul/05

Status: Closed
Project: Magnolia
Component/s: admininterface
Affects Version/s: 2.1 Final
Fix Version/s: 2.1 Final

Type: Bug Priority: Critical
Reporter: Michael Aemisegger Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

all


Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

The DialogMVCHandler has lost a feature compared to previous releases. It is less general.

It is not possible anymore to target any content container to store data entered through a dialog.

Following patch reintroduces this feature:

— originals/magnolia-2.1-SNAPSHOT/src/main/info/magnolia/module/admininterface/DialogMVCHandler.java 2005-07-13 17:15:08.000000000 +0200
+++ patched/magnolia-2.1-SNAPSHOT/src/main/info/magnolia/module/admininterface/DialogMVCHandler.java 2005-07-24 19:19:18.000000000 +0200
@@ -217,9 +217,14 @@
try {
Content parentContent = hm.getContent(path);
if (StringUtils.isEmpty(nodeName)) {
+ if (StringUtils.isEmpty(nodeCollectionName))

{ storageNode = parentContent; }

else

{ + storageNode = parentContent.getContent(nodeCollectionName); + }

+ }
+ else {
if (StringUtils.isEmpty(nodeCollectionName)) {
storageNode = parentContent.getContent(nodeName);



 Comments   
Comment by Philipp Bracher [ 25/Jul/05 ]

commited.

Thanks

Comment by Boris Kraft [ 26/Jul/05 ]

reassigned to RC3

Generated at Mon Feb 12 03:18:02 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.