[MAGNOLIA-511] Make it easiear to extend DialogDialog Created: 28/Jul/05 Updated: 23/Jan/13 Resolved: 17/May/06 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | admininterface |
| Affects Version/s: | 2.1 Final |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major |
| Reporter: | Michael Aemisegger | Assignee: | Boris Kraft |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
all |
||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Description |
|
I splitted the methods drawHtmlPostSubs(Writer) and drawHtmlPreSubs(Writer) into several methods and made them protected. Before, when extending DialogDialog.java a lot of unnecessary redundant code got spread all over the subclasses which is hard to maintain. Patch for revision 1139: — originals/magnolia-2.1-SNAPSHOT/src/main/info/magnolia/cms/gui/dialog/DialogDialog.java 2005-07-13 17:15:01.000000000 +0200 out.write("<html>"); //$NON-NLS-1$ + // else multiple paragraph selection -> radios for selection
public void drawHtmlPostSubs(Writer out) throws IOException { - Messages msgs = MessagesManager.getMessages(getRequest()); + this.drawHtmlPostSubsTabSet(out); + this.drawHtmlPostSubsButtons(out); + out.write("</form></body></html>"); //$NON-NLS-1$ + }+ + } |
| Comments |
| Comment by Philipp Bracher [ 17/May/06 ] |
|
looking forward to the next dialog generation |