[MAGNOLIA-5111] Time does not get saved, because date control ignores extends property Created: 13/Jun/13  Updated: 19/Dec/16  Resolved: 04/Aug/15

Status: Closed
Project: Magnolia
Component/s: admininterface
Affects Version/s: 4.4.11
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Nils Breunese Assignee: Unassigned
Resolution: Outdated Votes: 0
Labels: vpro
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MAGNOLIA-4497 Date Control: timeFormat and jsTimeFo... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

info.magnolia.module.admininterface.SaveHandlerImpl#processDate checks whether the configNode has a property called 'time' set to 'true' to decide whether or not to save the time part of the date. When a date control which doesn't have the 'time' property set extends another date control which does have 'time' set to 'true' this is ignored and the time is not saved.

This is a regression from 4.4.9-jr24, because with that version this worked fine for us.



 Comments   
Comment by Nils Breunese [ 13/Jun/13 ]

Changing 'extends' to 'reference' fixes our particular use case, because there was actually nothing added to the configuration that was 'extended'.

Comment by Nils Breunese [ 13/Jun/13 ]

Actually changing 'extends' to 'reference' did not fix our use case, because when using reference the node data name used to save the data in the repository is apparently the name of the target instead of the source. Is this intentional behavior? Was very unexpected to me.

In the end I just copied the dialog field configuration instead of trying to extend or reference it.

Comment by Michael Mühlebach [ 04/Aug/15 ]

We're closing this issue as outdated as it was reported for 4.4.x or earlier versions which are no longer supported. Don't hesitate to reopen or create a new ticket in case this is still relevant and you'll experience it on 4.5.x or later versions.

Generated at Mon Feb 12 04:02:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.