[MAGNOLIA-512] Make it easier to extend Save.java Created: 30/Jul/05  Updated: 17/Mar/09  Resolved: 10/Aug/05

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 2.1 Final
Fix Version/s: 2.1 Final

Type: Improvement Priority: Major
Reporter: Michael Aemisegger Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

all


Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

I don't know what your policy is regarding members of a class.

Do you want to make them protected or expose the members through protected / public getters and setters?

To minimize the change in code I've chosen to make the private members to protected.

Patch for revision 1139 (created with 'diff -uBbPr' on linux):
— originals/magnolia-2.1-SNAPSHOT/src/main/info/magnolia/cms/gui/control/Save.java 2005-07-13 17:15:01.000000000 +0200
+++ patched/magnolia-2.1-SNAPSHOT/src/main/info/magnolia/cms/gui/control/Save.java 2005-07-30 18:57:26.000000000 +0200
@@ -85,7 +85,7 @@
/**

  • The from, containing all the fields and files. This form is generated by magnolia.
    */
  • private MultipartForm form;
    + protected MultipartForm form;

/**

  • creates the node if it is not present
    @@ -96,7 +96,7 @@
    /**
  • The name of the repository to store the data. Website is default.
    */
  • private String repository = ContentRepository.WEBSITE;
    + protected String repository = ContentRepository.WEBSITE;

/**

  • Do not use this without a reason.


 Comments   
Comment by Philipp Bracher [ 01/Aug/05 ]

In common I prefere getter and setter methods since this brings more flexibility. So I will update the Save class using getters and setters.

Comment by Philipp Bracher [ 03/Aug/05 ]

i encapsulated the form and repository property

Generated at Mon Feb 12 03:18:09 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.