[MAGNOLIA-512] Make it easier to extend Save.java Created: 30/Jul/05 Updated: 17/Mar/09 Resolved: 10/Aug/05 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 2.1 Final |
| Fix Version/s: | 2.1 Final |
| Type: | Improvement | Priority: | Major |
| Reporter: | Michael Aemisegger | Assignee: | Philipp Bärfuss |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
all |
||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Description |
|
I don't know what your policy is regarding members of a class. Do you want to make them protected or expose the members through protected / public getters and setters? To minimize the change in code I've chosen to make the private members to protected. Patch for revision 1139 (created with 'diff -uBbPr' on linux):
/**
/**
|
| Comments |
| Comment by Philipp Bracher [ 01/Aug/05 ] |
|
In common I prefere getter and setter methods since this brings more flexibility. So I will update the Save class using getters and setters. |
| Comment by Philipp Bracher [ 03/Aug/05 ] |
|
i encapsulated the form and repository property |