[MAGNOLIA-5153] The support for @PostConstruct (JSR250) by using mycila-guice is not performant Created: 03/Jul/13 Updated: 31/Jan/14 Resolved: 22/Jul/13 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | 4.5.9, 5.0 |
| Fix Version/s: | 4.5.10, 5.0.2, 5.1 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Philipp Bärfuss | Assignee: | Jaroslav Simak |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | performance, rendering | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Release notes required: |
Yes
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
We saw 430'000 calls to the com.mycila.inject.internal.Signature.equals(Object) in the JProfiler. So we disabled the feature in info.magnolia.objectfactory.guice.GuiceComponentProviderBuilder by commenting out the following line of code: install(Jsr250.newJsr250Module()); The impact in reality needs to be tested as the instrumenting by the JProfiler might be misleading in this case. |
| Comments |
| Comment by Jan Haderka [ 19/Jul/13 ] |
|
Since this feature was already rolled out we can't just disable it. Instead we either need to figure out how to make it faster or make it configurable so those not using it can just switch it off. |
| Comment by Jaroslav Simak [ 22/Jul/13 ] |
|
JSR-250 can be enabled/disabled via magnolia.properties by adding this line: magnolia.jsr250.enabled=false |
| Comment by Jan Haderka [ 26/Jul/13 ] |
|
new flag should be described in installation and at page describing what to check/do for performance tuning (do we have such one at all?). |