[MAGNOLIA-5170] LegacyComponentsConfigurer can't work (in tests) when modules declare components in <properties> Created: 09/Jul/13 Updated: 07/Aug/13 Resolved: 10/Jul/13 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | testing |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.2, 5.1 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Magnolia International | Assignee: | Magnolia International |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
info.magnolia.objectfactory.configuration.LegacyComponentsConfigurer#addComponent registers a component twice - as a component, and as a type mapping. I experienced this while testing a ModuleVersionHandler, where the imaging module was involved (at the time of writing, the imaging module still has a component declared in <properties>. Workarounds:
Some more "interesting" observations that may or may not be related, but are probably due to other bugs in MgnlTestCase, RepositoryTestCase etc:
|
| Comments |
| Comment by Magnolia International [ 10/Jul/13 ] |
|
Committed a fix in AbstractComponentProvider which prevents the double-registration. Further improvements/fixes to the test framework could be helpful, but will be tackled with |
| Comment by Federico Grilli [ 29/Jul/13 ] |
|
If I understand correctly, now that this issue is fixed the workaround at JbpmWorkflowModuleVersionHandlerTest.java can be removed. |
| Comment by Magnolia International [ 29/Jul/13 ] |
|
Indeed - workaround now removed. Cheers. |