[MAGNOLIA-5188] Make Security and SecuritySupport IoC compliant Created: 16/Jul/13  Updated: 17/Jul/13  Resolved: 17/Jul/13

Status: Closed
Project: Magnolia
Component/s: security
Affects Version/s: 5.0
Fix Version/s: 5.1

Type: Improvement Priority: Major
Reporter: Daniel Lipp Assignee: Daniel Lipp
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   
  • Security should be deprecated - most methods can be called on SecuritySupport. Others (createSubjectAndPopulate & Security#mergePrincipals) should go to SecurityUtil


 Comments   
Comment by Daniel Lipp [ 16/Jul/13 ]

among others this would safe mocking effort in tests

Beware: first check whether IoC is already initialized before those types are used!

Comment by Daniel Lipp [ 17/Jul/13 ]

As we know there's issues consistently using IoC in security (repos are sometimes not yet ready when security is used) we didn't go as far as consistently using IoC in security code. This is the minimum: preparing for IoC and deprecated outdates stuff so it won't be used for new code.

Generated at Mon Feb 12 04:02:48 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.