[MAGNOLIA-5194] NewPropertyTask should be able to set property of any type Created: 23/Jul/13  Updated: 18/Dec/13  Resolved: 02/Aug/13

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 4.5.9
Fix Version/s: 4.5.10, 5.0.2, 5.1

Type: Improvement Priority: Neutral
Reporter: Robert Šiška Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MAGNOLIA-5493 NewPropertyTask throws NPE when node ... Closed
is causing MGNLRSSAGG-92 Fix RSSModuleFeedGeneratorTest Closed
dependency
is depended upon by MGNLFORM-148 The configuration of FORM between a n... Closed
relation
is related to MAGNOLIA-5205 SetPropertyTask should be able to set... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Bootstrapped configs of freshly installed modules can bring properties of any type while update tasks can only create String properties. That causes inconsistency between updated and installed modules.



 Comments   
Comment by Jan Haderka [ 27/Jul/13 ]

Same as for MAGNOLIA-5205 - you should avoid unnecessary casts.

Comment by Magnolia International [ 28/Jul/13 ]

And the copy-pastaed code !

Comment by Magnolia International [ 28/Jul/13 ]

I also notice that this commit changes (or adds?) usage of Content API to JCR API; while that's generally a good thing, it can not go unnoted. The very least you should do is mention it in the commit message !

Comment by Magnolia International [ 28/Jul/13 ]

Missing fix version for 5.0.x and 5.1, missing commit in 5.0.x branch

Comment by Milan Divilek [ 01/Aug/13 ]

Reopen: Don't make constructor with Object public.

Comment by Milan Divilek [ 01/Aug/13 ]

Reopen: HierarchyManager.getContent(nodePath) support relative path from root node and absolute path. But after rewrite to session api only absolute path works. So backward compatibility is broken.

Comment by Jan Haderka [ 02/Aug/13 ]

MgnlContext vs. installContext use for session retrieval.

Generated at Mon Feb 12 04:02:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.