[MAGNOLIA-5205] SetPropertyTask should be able to set property of any type Created: 26/Jul/13 Updated: 18/Dec/13 Resolved: 02/Aug/13 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 4.5.9 |
| Fix Version/s: | 4.5.10, 5.0.2, 5.1 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Robert Šiška | Assignee: | Milan Divilek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Description |
|
Bootstrapped configs of freshly installed modules can bring properties of any type while update tasks can only create String properties. That causes inconsistency between updated and installed modules. |
| Comments |
| Comment by Jan Haderka [ 27/Jul/13 ] |
|
I really don't like casting type to Object and then later checking for type and casting it back. Type checking and casting are very slow if nothing else. |
| Comment by Magnolia International [ 28/Jul/13 ] |
|
I was going to reopen for the same reason but not with the same reasoning Moreover, this will introduce unwanted bugs if existing properties is of a different type. NewPropertyTask was a good candidate for such a change, and so would CheckAndModifyPropertyValueTask - since it enforces a check on the current value before modifying it. |
| Comment by Magnolia International [ 28/Jul/13 ] |
|
Missing fix version for 5.0.x and 5.1, missing commit in 5.0.x branch |
| Comment by Milan Divilek [ 01/Aug/13 ] |
|
Reopen: Don't make constructor with Object public. |
| Comment by Milan Divilek [ 01/Aug/13 ] |
|
Wrong ticket number was used in commit message. |
| Comment by Milan Divilek [ 01/Aug/13 ] |
|
Reopen: HierarchyManager.getContent(nodePath) support relative path from root node and absolute path. But after rewrite to session api only absolute path works. So backward compatibility is broken. |