[MAGNOLIA-5231] Don't use org.apache.commons.lang.exception.NestableException any longer Created: 08/Aug/13  Updated: 13/Aug/13  Resolved: 08/Aug/13

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 5.0.1
Fix Version/s: 5.0.2, 5.1

Type: Task Priority: Neutral
Reporter: Daniel Lipp Assignee: Daniel Lipp
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-5232 Update version of commons-lang Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty

 Description   

NestableException had been introduced before Exceptions could be nested out of the box (introduced with Java 1.4). Looks like we overlooked one place where we still used it: MgnlCommand#executeSynchronzide

try {
    success = cmd.execute((info.magnolia.context.Context) ctx);
} catch (Exception e) {
    throw new NestableException("Exception during executing command", e);
} finally {
    cmd.release();
}

The ugly consequence is that - in case of exceptions - we get unnecessarily long stack traces.



 Comments   
Comment by Daniel Lipp [ 08/Aug/13 ]

NestableException isn't around in newer versions of commons-lang

Comment by Daniel Lipp [ 13/Aug/13 ]

backporting to 5.0.2

Comment by Daniel Lipp [ 13/Aug/13 ]

backport done

Generated at Mon Feb 12 04:03:13 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.