[MAGNOLIA-5242] cmsfn.isEditMode() is true when accessing a page outside page editor Created: 16/Aug/13  Updated: 24/Aug/13  Resolved: 19/Aug/13

Status: Closed
Project: Magnolia
Component/s: rendering, templating
Affects Version/s: 5.0.2
Fix Version/s: 5.0.3, 5.1

Type: Bug Priority: Critical
Reporter: Roman Kovařík Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MGNLUI-1902 cmsfn.isPreviewMode() is always false Closed
is causing MGNLUI-1955 Following a link in page-editor turns... Closed
relation
is related to MAGNOLIA-5236 Optional area not added on author ins... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

MGNLUI-1902 fix bug when cmsfn.isPreviewMode() was always false. But the fix covers only the case when being in page editor.
MgnlContext.getAggregationState().isPreviewMode() is still false for accessing the page without editor (http://demoauthor.magnolia-cms.com/demo-project.html)
This should be true or we need something to check that we are not in edit mode
If not, pages in preview/direct access can be different, for example empty optional areas won't be rendered in page editor preview or on public, but will be rendered with direct page access on author (http://demoauthor.magnolia-cms.com/demo-project.html).



 Comments   
Comment by Philipp Bärfuss [ 19/Aug/13 ]

Raising to critical level.

Generated at Mon Feb 12 04:03:19 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.