[MAGNOLIA-5250] fckEditor: make repository browser site aware Created: 21/Aug/13  Updated: 24/Oct/13  Resolved: 26/Aug/13

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 4.5.3
Fix Version/s: 4.5.11

Type: Bug Priority: Major
Reporter: Zdenek Skodik Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Cloners
is cloned by MGNLADMLEG-20 CLONE - fckEditor: make repository br... Closed
Relates
relates to MGNLETK-109 fckEditor: repository browser doesn't... Closed
relation
is related to MAGNOLIA-3972 Image broken links when using both DM... Closed
is related to MAGNOLIA-4401 Simplify EditorLinkTransformer Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

EditorLinkTransformer refactoring done for 4.5.3 introduced a bug to the transformer application at fckEdit control. When your site definition shortens URL, FckEditorDialog#convertToView(string) interprets the link stored in repository incorrectly causing in turn the repository browser dialog to not expand the tree down to the linked target, but just renders the nodes from first level directly, if you're about to update an existing link.

To reproduce:

  1. shorter URL at your site definition mapping
  2. create a link to a page from this site at fckEditor
  3. save the dialog, reopen, try to edit that link


 Comments   
Comment by Jan Haderka [ 22/Aug/13 ]

what if someone is not using url shortening or is linking content belonging to different site? Wouldn't your fix break the tree browser in that case?
There should be tests covering those scenarios.

Also in case of LinkException, we should revert to original behaviour, don't you think?

And last but not least why are tests expecting to get back urls starting with "null". This seems incorrect and if there is deeper meaning (e.g. trying to avoid complicated setup for tests) it should be explained in the comment in the test itself.

Generated at Mon Feb 12 04:03:23 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.