[MAGNOLIA-5311] XML import should prevent duplicate node names Created: 13/Sep/13 Updated: 01/Nov/13 Resolved: 31/Oct/13 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | 4.5.11, 5.0.4 |
| Fix Version/s: | 4.5.13 |
| Type: | Bug | Priority: | Major |
| Reporter: | Joerg von Frantzius | Assignee: | Peili Liang |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Epic Link: | Support | ||||||||||||||||||||
| Sprint: | 4.5.13 | ||||||||||||||||||||
| Description |
|
Currently the XML import will allow the XML to contain duplicate node names and import them. Since Magnolia doesn't support duplicate node names in a lot of places (e.g. versioning and activation), this can lead to serious problems. This can happen with XML generated outside of Magnola or hand-written/modified XML. The XML import logic should either reject the import or rename nodes appropriately while importing. |
| Comments |
| Comment by Christoph Meier [ 21/Oct/13 ] |
|
To resolve this issue, something in DataTransporter#importXmlStream must be changed. |
| Comment by Christoph Meier [ 22/Oct/13 ] |
|
I tried another solution, too. Unfortunately this approach also fails; again during installation occurs an exception: |
| Comment by Christoph Meier [ 22/Oct/13 ] |
|
I'm not sure whether this ticket really can be resolved. |
| Comment by Peili Liang [ 25/Oct/13 ] |
|
Use alertUtil to report error to user which has no internationalization. |
| Comment by Christoph Meier [ 28/Oct/13 ] |
|
Review: all fine. (earlier complaint due to nev.ironment-problems of the reviewer) |
| Comment by Jan Haderka [ 29/Oct/13 ] |
|
Looks great. Just two tiny remarks:
|
| Comment by Cheng Hu [ 30/Oct/13 ] |
|
There are currently two questions with this issue:
|
| Comment by Cheng Hu [ 31/Oct/13 ] |
|
Spoke to Jan and agreed to use iteration since that is the solution that experience has shown to be problem-free. Solution has been changed to iteration and pushed. |
| Comment by Jan Haderka [ 31/Oct/13 ] |
|
After discussion in the architecture group here is what we agreed upon: Since it is unlikely that Magnolia will support same name siblings in near future, we
|
| Comment by Christopher Zimmermann [ 31/Oct/13 ] |
|
Created story: http://jira.magnolia-cms.com/browse/MAGNOLIA-5433 to implement above decision. |
| Comment by Christopher Zimmermann [ 01/Nov/13 ] |
|
For 4.5 we use this fix. |