[MAGNOLIA-5337] MarkNodeAsDeletedCommand mark only child items as deleted Created: 25/Sep/13 Updated: 17/Dec/13 Resolved: 12/Nov/13 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.2 |
| Type: | Bug | Priority: | Major |
| Reporter: | Milan Divilek | Assignee: | Peili Liang |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Sprint: | 5.2-rc1, 5.1.1, 5.2-beta1 | ||||||||||||||||||||
| Description |
|
MarkNodeAsDeletedCommand mark only child items as deleted but not folders and their child nodes. Reproduce in contact app:
Then select rootFolder and use Delete folder action. Confirm warning about "the node and its sub nodes will be marked for deletion". RootFolder and contactInRootFolder will be correctly marked as deleted, but subFolder and contactInSubFolder not. |
| Comments |
| Comment by Eric Hechinger [ 23/Oct/13 ] |
|
This fix is causing |
| Comment by Christopher Zimmermann [ 24/Oct/13 ] |
|
From Jan:"only contact should be versionable, but it seems that somehow version manager is trying to version photo of the contact on it's own as well". I think that versioning the image should at least be considered - it would be nice to version the image if possible. Consider assets especially. |
| Comment by Eric Hechinger [ 24/Oct/13 ] |
|
Another hint: Deletion of a folder use the same command 'MarkNodeAsDeletedCommand' as the deletion of an Item (contact). This command create version's, but the mgnl:folder nodeType is not configured to support versions. Suggestion (to be discuss with architects)
|
| Comment by Jan Haderka [ 08/Nov/13 ] |
make sure to not mistake mgnl:versionable with mix:versionable
What parameter? I know you mentioned above that command was not designed to handle recursively, but i still don't understand why this should be switchable? When you delete something, everything underneath has to be marked as deleted as well because it can't be available anymore to any other part of Magnolia (templates, navigation, links, etc) so it has to be always recursive. Why the parameter then? |
| Comment by Jaroslav Simak [ 17/Dec/13 ] |
|
Reverted as part of |