[MAGNOLIA-534] Bar control uses hardcoded CSS classes Created: 30/Aug/05 Updated: 17/Mar/09 Resolved: 02/Sep/05 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 2.1 Final |
| Type: | Bug | Priority: | Major |
| Reporter: | Martin Wehner | Assignee: | Philipp Bärfuss |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: |
| Description |
|
The Bar control class uses hardcoded CSS classes instead of using getCssClass() (like Button correctly does). So you'd have to override the whole getHtml() method to implement a custom bar using another CSS class. |
| Comments |
| Comment by Martin Wehner [ 30/Aug/05 ] |
|
This patch makes Bar use the custom CSS class if one is set, and the default ones if none is set. |
| Comment by Martin Wehner [ 30/Aug/05 ] |
|
Added a nicer version of the patch which uses getHtmlCssClass() to render the class attribute. |
| Comment by Philipp Bracher [ 02/Sep/05 ] |
|
I applied successfully this patch thanks. I will commit to 2.1 branch and merge with 2.2 trunk later |