[MAGNOLIA-5350] An i18n text (label, description, ...) specified in config is not always used Created: 01/Oct/13 Updated: 25/Oct/13 Resolved: 16/Oct/13 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | i18n |
| Affects Version/s: | 5.1 |
| Fix Version/s: | 5.1.1 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Jozef Chocholacek | Assignee: | Christopher Zimmermann |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | i18n | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Epic Link: | i18n Epic | ||||||||||||||||
| Sprint: | 5.1.1 | ||||||||||||||||
| Description |
|
If an i18n text (e.g. label) is specified in configuration, and one of the generated keys has a translation, the specified text is ignored, and a translation for the generated key is used. E.g. if you have a commit action in a dialog and you "hardcode" a label for it in configuration (e.g. to "Save My Changes"), it is always ignored, as one of the keys from the ActionDefinitionKeyGenerator is action.commit.label, whose translation is specified in admincentral's mgnl-i18n/messages_en.properties bundle, thus this translation ("save changes") is used, overriding the specified value. |
| Comments |
| Comment by Magnolia International [ 10/Oct/13 ] |
|
Totally untested patch. Needs a battery of tests, coverage can't go down ! |
| Comment by Christopher Zimmermann [ 16/Oct/13 ] |
|
Decorator now only decorates if value is null. With test. So now in configuration you can set a label property on a subapp for example - the value can either be the actual label, or it can be a key. |