[MAGNOLIA-5351] Moved or deleted items (pages, components) do NOT update activation status Created: 01/Oct/13  Updated: 22/Jan/15  Resolved: 11/Oct/13

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 5.1
Fix Version/s: 5.1.1

Type: Bug Priority: Blocker
Reporter: Jozef Chocholacek Assignee: Jan Haderka
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File LastUpdateContentDecorator.java     Text File LastUpdateNodeWrapper.java     Text File magnolia-5351.patch    
Issue Links:
Relates
relates to MAGNOLIA-5389 Remove now obsolete calls to NodeType... Closed
relates to MAGNOLIA-6036 mgnl:lastModified not being updated o... Closed
causality
is causing MGNLDAM-327 Dam: Duplicating asset throws exception Closed
is causing MGNLUI-2325 Saving group in security app fails wi... Closed
is causing MAGNOLIA-5360 Remove Delete/Modify actions from Int... Closed
is causing MAGNOLIA-5361 Remove Last Update Date updates from ... Closed
dependency
depends upon MAGNOLIA-5362 Introduce mechanism for performing wr... Closed
depends upon MAGNOLIA-5385 Make Autogeneration thread/clustering... Closed
relation
is related to MAGNOLIA-5375 Add configuration possibility to Impo... Closed
is related to MAGNOLIA-5502 Template change does not update the s... Closed
is related to MAGNOLIA-5391 Modification status for user is not c... Closed
is related to MGNLSTK-1256 Update demo project bootstrap files t... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Date of First Response:
Sprint: 5.1 - Final, 5.1.1

 Description   

How to reproduce:

  1. just move the page somewhere else ... or component for that matter. Or even delete a component. - the status icon remains green, but in fact the page was modified.


 Comments   
Comment by Jan Haderka [ 01/Oct/13 ]

IMHO this is a blocker for 5.1 ... or in worst case should be solved in 5.1.1 if we are going to release it asap after 5.1. This issue is one of those that makes using Magnolia in production unreliable.

I would also argue that this should NOT be UI issue and should be fixed in node/session/workspace wrappers in move/copy methods since not every time is moving result of ui action.

Comment by Jan Haderka [ 02/Oct/13 ]

looking into this issue further

  • Activation status is still calculated property.
  • Value "modified" is determined by comparing mgnl:lastModified vs. mgnl:lastActivated
  • mgnl:lastModified is NOT updated on move of the content.
  • moving of components in the page also doesn't lead to "modified" activation status
  • deletion of components also doesn't change activation status

Deletion and moving should be handled by InterceptFilter so it would seem that either this filter doesn't recognise the action anymore or it is doesn't update the status correctly.

Comment by Jan Haderka [ 03/Oct/13 ]

Patch showing modified existing code and new wrapper and decorator to deal with the problem.

Related: 2013-10-03 11:18:25,665 WARN info.magnolia.jcr.util.NodeTypes : Trying to set property/ies 'mgnl:lastModified, mgnl:lastModifiedBy' although the node '/eric/favorites' with PrimaryType 'nt:unstructured' is not of type 'mgnl:lastModified'!
... this happens now because wrapper sets LUD for all nodes - should it not? Should it filter out based on node type? or should NodeTypes.LastUpdate.update() ignore it silently?

Comment by Jan Haderka [ 03/Oct/13 ]

Resolved on branch.

Comment by Jan Haderka [ 04/Oct/13 ]

Rolled back from master due to race condition failure exposed by integration tests.

Comment by Jozef Chocholacek [ 07/Oct/13 ]

Also imported items (pages, assets) keep their (wrong) status.

Comment by Jan Haderka [ 11/Oct/13 ]

Resolved on magnolia-5.1-locking branch.

Generated at Mon Feb 12 04:04:20 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.