[MAGNOLIA-5353] VirtualURIMapping: fallback to path if uuid gets changed Created: 02/Oct/13 Updated: 20/Mar/15 Resolved: 25/Oct/13 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.5.13, 5.2 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Zdenek Skodik | Assignee: | Cheng Hu |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Date of First Response: | |||||||||||||
| Epic Link: | Support | ||||||||||||
| Sprint: | 4.5.13 | ||||||||||||
| Description |
|
The module's virtualURIMapping node used to not be bootstrapped but autogenerated with random uuid by the module mechanism. VirtualURIManager caches the defined mappings and reloads them upon a change to any mapping's configuration. This is based on node uuids. If one does such change and doesn't activate the particular mapping but the whole virtualURIMapping node, the uuid at Public gets changed and the manager is not able to reload it as it expects the former uuid. This causes all the module's mappings to not be working and the only way to fix it is to restart the webapp so that the manager registers all the existing mappings from scratch. We should fallback to path in such case. |
| Comments |
| Comment by Jan Haderka [ 28/Oct/13 ] |
|
Few Comments, not necessarily in order of importance:
|
| Comment by Cheng Hu [ 28/Oct/13 ] |
These changes have been made in the new push on the issue branch. |
| Comment by Jozef Chocholacek [ 28/Oct/13 ] |
|
My objections go more into the test:
And the class itself (line #145): protected static Node getNodeByIdentifierOrPath(...) throws ItemNotFoundException, RepositoryException { The ItemNotFoundException is a subclass of the RepositoryException, thus no need to mention it twice, IMO. |
| Comment by Cheng Hu [ 28/Oct/13 ] |
|
@Jozef thanks for pointing these out.
These changes have been made in the new push on the issue branch. |
| Comment by Jan Haderka [ 29/Oct/13 ] |
|
Looks great, just one tiny thing: + * @param uuid + * @param path If you are not providing any info for those params, there's no need to add them to javadoc as they will be added there automatically once javadoc is generated. |
| Comment by Tobias Mattsson [ 20/Mar/15 ] |
|
A better solution would have been to fix |