[MAGNOLIA-5356] Web.xml uses 2.5 and 3.0 features but specifies 2.4 Created: 03/Oct/13  Updated: 04/Dec/13  Resolved: 03/Oct/13

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: 5.2

Type: Bug Priority: Critical
Reporter: Tobias Mattsson Assignee: Tobias Mattsson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLEE-154 Configure bundled Tomcat to use UTF-8... Closed
causality
caused by MAGNOLIA-4911 Sticky "jsessionid" URL parameter cau... Closed
caused by MGNLUI-1911 Move back applauncher configuration t... Closed
dependency
depends upon MAGNOLIA-5382 Handling of URIs and paths with path ... Closed
duplicate
duplicates MAGNOLIA-5130 5.0 war fails to deploy on Glassfish 4.0 Closed
relation
is related to MAGNOLIA-4942 Re-enable loginOnAuthorInstanceWithSu... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: 5.1 - Final, 5.2-rc1, 5.1.1

 Description   

We're using the metadata-complete attribute that was added in 2.5, but we're specifying 2.4 preventing it from starting in JBoss AS 7 because web.xml does not validate.

The metadata-complete attribute should be removed and the namespace declaration updated to 2.5.

The namespace declaration should be:

<?xml version="1.0" encoding="UTF-8"?>
<web-app xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd" version="2.5">

It currently is:

<?xml version="1.0" encoding="UTF-8"?>
<web-app xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee http://java.sun.com/xml/ns/j2ee/web-app_2_4.xsd" metadata-complete="true" version="2.4">

We're also using the <tracking-mode> tag to specify cookie tracking. This is a Servlet 3.0 feature. JBoss AS 7 seems to ignore that while JBoss AS 6 fails to start. It should also be removed.

  <session-config>
    <tracking-mode>COOKIE</tracking-mode>
  </session-config>


 Comments   
Comment by Magnolia International [ 03/Oct/13 ]

We might fix the tracking-mode issue by patching the Tomcat configuration for the bundles. See MGNLEE-154.

Comment by Tobias Mattsson [ 03/Oct/13 ]

The metadata-complete="true" was added by mistake and will be removed.

The <tracking-mode> will also be removed, will need to be solved in MGNLEE-154 instead.

Comment by Tobias Mattsson [ 03/Oct/13 ]

The places I've found where it needs to be changed are

  • magnolia-empty-webapp
  • magnolia-enterprise-websphere-webapp

and for tests in

  • magnolia-core
  • magnolia-templating
  • magnolia-templating-jsp
Comment by Tobias Mattsson [ 03/Oct/13 ]

On branch at https://git.magnolia-cms.com/gitweb/?p=magnolia_main.git;a=commit;h=e65cc3c11c14b3870c6003fee3a4f572ffc46873 and https://git.magnolia-cms.com/gitweb/?p=ce-bundle.git;a=commit;h=05dac31902cfe0952178add485f49cfcfb05fbed

Comment by Tobias Mattsson [ 03/Oct/13 ]

See also MAGNOLIA-3841 the last comment seems to mention the same problem as MAGNOLIA-4911

Comment by Tobias Mattsson [ 03/Oct/13 ]

Added a comment on MAGNOLIA-4911 explaining the problem there in more detail.

Generated at Mon Feb 12 04:04:23 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.