[MAGNOLIA-536] Make it easier to extend Created: 01/Sep/05  Updated: 17/Mar/09  Resolved: 02/Sep/05

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 2.1 Final
Fix Version/s: 2.1 Final

Type: Improvement Priority: Major
Reporter: Michael Aemisegger Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

all


Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

if getHierarchyManager() is private, a lot of redundant code has to be maintained in the subclass.

Note that the patch format below is different from the previos ones. The patch is directly extracted from my own global patch file. I hope you can apply the patch via command line the usual way. If not, I always can produce a special patch for you. Let me know.

patch for revision 1437 of tagged version /magnolia2.1 :

— /home/maem/workspace/Pagnolia2.1/src/originals/magnolia-2.1/src/main/info/magnolia/cms/exchange/simple/SimpleExchangeServlet.java 2005-08-31 11:29:13.000000000 +0200
+++ /home/maem/workspace/Pagnolia2.1/src/patched/magnolia-2.1/src/main/info/magnolia/cms/exchange/simple/SimpleExchangeServlet.java 2005-08-31 11:31:31.000000000 +0200
@@ -275,7 +275,7 @@
}
}

  • private HierarchyManager getHierarchyManager() throws Exception {
    + protected HierarchyManager getHierarchyManager() throws Exception { return this.hierarchyManager; }


 Comments   
Comment by Michael Aemisegger [ 01/Sep/05 ]

Should read 'Make it easier to extend SimpleExchangeServlet'

Comment by Philipp Bracher [ 02/Sep/05 ]

will commit to 2.1 branch and merge with 2.2 turnk later

Generated at Mon Feb 12 03:18:24 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.