[MAGNOLIA-5364] Cannot reload message bundles Created: 08/Oct/13  Updated: 25/Oct/13  Resolved: 15/Oct/13

Status: Closed
Project: Magnolia
Component/s: i18n
Affects Version/s: 5.1
Fix Version/s: 5.1.1

Type: Bug Priority: Neutral
Reporter: Jozef Chocholacek Assignee: Jozef Chocholacek
Resolution: Fixed Votes: 0
Labels: i18n
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLADMLEG-24 Call TranslationService.reloadMessage... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Date of First Response:
Sprint: 5.1.1

 Description   

Regression: There is a "Reload i18n properties files" option in Dev Tools app, but it does not work anymore. Without this functionality, each change in the bundles requires restart to show in UI.



 Comments   
Comment by Daniel Lipp [ 15/Oct/13 ]

Powermock should also be defined in dependencyMgmt section of magnolia-project (as all the other third parties). For consistency reasons I'd also remove the powermock property but use explicit versions (as e.g. for the org.bouncycastle libs). Also I think there's a newer version of powermock (1.5.1). Why not use that one right from the start?

Last but not least about the unit-test itself:

  • setUp uses ComponentsTestUtil but there's no tearDown to unset those -> could provoke failures in tests running after this one
  • I'd name it TranslationServiceImplReloadBundleTest -> then it's clear it's not a unit-test for a type called ReloadBundles
  • field USERLOCALE seems to be unused
Comment by Jozef Chocholacek [ 15/Oct/13 ]

We have to use PowerMock version 1.4.9 as we use Mockito version 1.8.5.

Generated at Mon Feb 12 04:04:27 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.