[MAGNOLIA-5372] Images/Resources without size property don't get served. Created: 09/Oct/13  Updated: 25/Oct/13  Resolved: 10/Oct/13

Status: Closed
Project: Magnolia
Component/s: templating
Affects Version/s: 4.5.12
Fix Version/s: 4.5.13, 5.1.1

Type: Bug Priority: Major
Reporter: Rico Jansen Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: VPRO
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

OS X, Java 6, Mysql


Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: 5.1.1

 Description   

Some of the images that we have in our media repository don't get served properly. They throw a PathNotFoundException.

This is caused by an attempt to access the size property which they don't have.

In the Magnolia 4.4.12 version this does not happen.
The difference is caused by that in info.magnolia.module.templating.RenderingFilter

String sizeString = atom.getAttribute("size"); //$NON-NLS-1$

Returns an empty string on no size property and in version 4.5.12
info.magnolia.rendering.engine.RenderingFilter

Property sizeProperty = atom.getProperty("size");

throws a PathNotFoundException



 Comments   
Comment by Daniel Lipp [ 09/Oct/13 ]

I assume this bug is still around in 5.1. Pls double check and if true, port the fix.

Generated at Mon Feb 12 04:04:32 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.