[MAGNOLIA-5388] Fix command API and enable custom configuration of commands Created: 15/Oct/13 Updated: 25/Oct/13 Resolved: 18/Oct/13 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 5.0 |
| Fix Version/s: | 5.1.1 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Milan Divilek | Assignee: | Milan Divilek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | 5.1.1 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
Copy method in MgnlCommand create new instance of command and copy value of enabled property in to new instance. Same is done in BaseRepositoryCommand where enabled, repository, uuid and path properties are copied to new instance. So if any Command extends MgnlCommand or BaseRepositoryCommand and has own property then you have to override copy method. Instead of this MgnlCommand should do copy of old command. |
| Comments |
| Comment by Daniel Lipp [ 18/Oct/13 ] |
|
We can deprecate the copy method but not remove it - especially not in a minor release. Also I'd love to have a clearer title + description so that everybody e.g. gets why we're now using standard java cloning. |