[MAGNOLIA-5421] MgnlAuditLoggingContentDecoratorNodeWrapper ignores property types Created: 24/Oct/13  Updated: 01/Nov/13  Resolved: 30/Oct/13

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: None
Fix Version/s: 4.5.13, 5.1.2, 5.2

Type: Bug Priority: Critical
Reporter: Philip Mundt Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MAGNOLIA-4778 Audit log is (partially) not working ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Support
Sprint: 4.5.13

 Description   

info.magnolia.audit.MgnlAuditLoggingContentDecoratorNodeWrapper ignores type when setting a property of sepcific type in:

  • setProperty(String name, Value value, int type)
  • setProperty(String name, Value[] values, int type)
  • setProperty(String name, String[] values, int type)
  • setProperty(String name, String value, int type)


 Comments   
Comment by Jozef Chocholacek [ 28/Oct/13 ]

Deserves a test to avoid regressions.

Comment by Jan Haderka [ 29/Oct/13 ]

I would argue that those tests you have added would have much more value (for very little effort) if you have used also different types in different tests instead of boolean everywhere and if those calls to methods that take arrays had more then one value in the array.

Comment by Milan Divilek [ 30/Oct/13 ]

Added fix Version 5.1.2 -> need to be ported to magnolia-5.1.x branch

Generated at Mon Feb 12 04:05:00 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.