[MAGNOLIA-5447] CheckAndModifyPropertyValueTask should offer a way to not fail on missing nodes Created: 04/Nov/13 Updated: 10/Jan/14 Resolved: 10/Jan/14 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | updatemechanism |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Jozef Chocholacek | Assignee: | Daniel Lipp |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
The CheckAndModifyPropertyValueTask is used to modify properties of nodes that might be already not present (due to user changes). In such situation, it causes an installation/update error - but many times such missing node is not a reason to abort the module installation/update. I suggest to add new constructor with a boolean strict parameter, that will indicate whether an error (if true) or just a warning shall be issued in case that the specified node is not found. The current constructors will call the new one with the strict parameter set to true, to keep the current contract. |
| Comments |
| Comment by Daniel Lipp [ 10/Jan/14 ] |
|
The wanted behavior can already be achieved by wrapping the task in a ConditionalDelegateTask. |