[MAGNOLIA-5455] Replace use of queries with node traversal in user, group and role -managers Created: 06/Nov/13 Updated: 22/Oct/14 Resolved: 06/Nov/13 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.2 |
| Type: | Task | Priority: | Neutral |
| Reporter: | Tobias Mattsson | Assignee: | Tobias Mattsson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||
| Task DoR: |
Empty
|
||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||
| Sprint: | 5.2-rc1 | ||||||||||||||||||||||||
| Description |
|
Using queries doesn't work before the session is saved. During install/update we often bootstrap in users, roles and groups and later use the managers to modify them. Because queries are used the managers can't find them. We should instead traverse the workspaces and find them that way. Initially we suspected this to be a problem with sessions not being synched, the first commit addresses this but it turned out not to be the problem. Disregard this commit. |
| Comments |
| Comment by Daniel Lipp [ 11/Nov/13 ] |
|
info.magnolia.cms.security.MgnlRoleManager#removePermission and info.magnolia.cms.security.MgnlRoleManager#addPermission should also use the system session |