[MAGNOLIA-5495] Use polling instead of waiting a safe amount of time when testing observing managers Created: 17/Nov/13 Updated: 18/Nov/13 Resolved: 17/Nov/13 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.5.14, 5.0.5, 5.1.2, 5.2 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Tobias Mattsson | Assignee: | Tobias Mattsson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Sprint: | 5.2-rc2 | ||||||||
| Description |
|
Instead of waiting 6 seconds to make sure that the manager has updated before testing that it did it correctly we should wait 1 second, then poll repeatedly until we see the desired change. If it doesn't happen in 10 seconds we can give up and let the test fail. For the two tests concerned, ConfiguredRendererManagerTest and ConfiguredTemplateDefinitionManagerTest this saves us 10 seconds in the build. See also |
| Comments |
| Comment by Daniel Lipp [ 18/Nov/13 ] |
|
Only tests were changed - as they still run, acceptance is <done>. |