[MAGNOLIA-5522] CommandsManager should be reimplemented to extend ModuleConfigurationObservingManager Created: 02/Dec/13 Updated: 23/Jan/17 Resolved: 12/Feb/16 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | None |
| Fix Version/s: | 5.4.5 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Tobias Mattsson | Assignee: | Tobias Mattsson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | architecture | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 10m | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||
| Sprint: | Kromeriz 30 | ||||||||||||||||||||||||||||||||||||
| Story Points: | 3 | ||||||||||||||||||||||||||||||||||||
| Description |
|
Adding a "commands" node under a module requires restart. While the manager reloads configuration it is missing definitions and executing commands will fail. Once this and |
| Comments |
| Comment by Roman Kovařík [ 04/Jan/16 ] |
Is this part of the description valid? |
| Comment by Jan Haderka [ 04/Jan/16 ] |
|
If nothing else is using ObservedManager, we should indeed deprecate it so it can be dropped in the future. |
| Comment by Roman Kovařík [ 04/Jan/16 ] |
|
It's used by info.magnolia.module.ModuleLifecycleContextImpl so this probably goes beyond this ticket. |
| Comment by Roman Kovařík [ 22/Jan/16 ] |
|
Reopened: |