[MAGNOLIA-5558] MarkNodeAsDeletedCommand is not flexible enough to deal with different node types Created: 22/Nov/13  Updated: 06/Feb/14  Resolved: 17/Dec/13

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 5.2
Fix Version/s: 5.2.1

Type: Bug Priority: Critical
Reporter: Tom Wespi Assignee: Jaroslav Simak
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Magnolia CE 5.2


Attachments: PNG File subtree-deletion.png    
Issue Links:
causality
caused by MAGNOLIA-5492 RestorePreviousVersionAction should r... Closed
is causing MAGNOLIA-5494 Cannot delete (by mark node as delete... Closed
relation
is related to MAGNOLIA-5414 Error is shown when deleting contact ... Closed
is related to MAGNOLIA-5337 MarkNodeAsDeletedCommand mark only ch... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

2013-11-22 16:54:56,130 ERROR info.magnolia.cms.core.version.BaseVersionManager : failed to copy versionable node to version store, reverting all changes made in this session

Deleting in JCR Browser is working. Also a new created page is possible to delete.



 Comments   
Comment by Christoph Meier [ 13/Dec/13 ]

Observation (CE; 5.1.1-final; updated with 5.2-final)
One single page which has no children: deletion works
A subtree of pages: deletion fails
=> 2013-12-13 14:56:13,552 ERROR info.magnolia.cms.core.version.BaseVersionManager : failed to copy versionable node to version store, reverting all changes made in this session.

After updating with 5.2.1-SNAPSHOT (Build #3802 (13.12.2013 14:13:38)) still the same behaviour.
(single page can be deleted, pages-subtree cannot be deleted => 2013-12-13 15:30:50,589 ERROR info.magnolia.cms.core.version.BaseVersionManager : failed to copy versionable node to version store, reverting all changes made in this session)

Comment by Christoph Meier [ 16/Dec/13 ]

next test:
clean installation 5.2.1-SNAPSHOT (build 3808)
try it again.

a) delete a subtree of pages
=> works fine

b) first publish a subtree of pages, later on delete the same subtree
=> fails (single pages still can be deleted, but not a subtree which has been activated before)
=> 2013-12-16 10:43:10,633 ERROR info.magnolia.cms.core.version.BaseVersionManager : failed to copy versionable node to version store, reverting all changes made in this session

Comment by Jaroslav Simak [ 17/Dec/13 ]

Part of this fix was also reverting MAGNOLIA-5492, MAGNOLIA-5337 and MAGNOLIA-5414.

https://git.magnolia-cms.com/gitweb/?p=magnolia_main.git;a=commit;h=b64be35cd595ace027ca130947b61cc25059f687

Generated at Mon Feb 12 04:06:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.