Revise implementation of delta tasks (MAGNOLIA-5571)

[MAGNOLIA-5578] Create constructors with autogenerated name and description for common delta tasks Created: 30/Dec/13  Updated: 12/Nov/14  Resolved: 29/Jan/14

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 5.0
Fix Version/s: 5.2.2

Type: Sub-task Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MAGNOLIA-5781 NPE when using BootstrapConditionally... Closed
dependency
is depended upon by MAGNOLIA-5644 Use new delta tasks constructors Closed
Template:
Date of First Response:

 Description   
  • Bunch of update task can autogenerate name and description.
  • We need to pass workspace as parameter in bunch of tasks, although it's almost always 'config' workspace.


 Comments   
Comment by Roman Kovařík [ 13/Jan/14 ]

Reverted until we'll find cause of Hudson bundle failure...

Comment by Daniel Lipp [ 24/Jan/14 ]

Ok, many of those changes are very basic but I'd at least expect a few unit-tests for the new constructors: e.g. for PropertyExistsDelegateTask and IsModuleInstalledOrRegistered

After all we're adding a lot of code with this commit and we should make sure there's no bugs in.

On top I'd expect a linked ticket to actually make use of these constructors: I'm pretty sure there's many places in our codebase where it would be handy. After all that was the motivation to add the new stuff, no

Comment by Roman Kovařík [ 27/Jan/14 ]

Ok, many of those changes are very basic but I'd at least expect a few unit-tests for the new constructors: e.g. for PropertyExistsDelegateTask and IsModuleInstalledOrRegistered
After all we're adding a lot of code with this commit and we should make sure there's no bugs in.

http://git.magnolia-cms.com/gitweb/?p=magnolia_main.pub.git;a=commit;h=2c4a9e5e75ff0e52fdb4de6389ce4c3a5984b3af

On top I'd expect a linked ticket to actually make use of these constructors: I'm pretty sure there's many places in our codebase where it would be handy. After all that was the motivation to add the new stuff, no

MAGNOLIA-5644

Comment by Jaroslav Simak [ 28/Jan/14 ]
  • unify namings - sometimes you use 'xxx repository', sometimes 'xxx workspace' - we have currently one repository called 'magnolia' and underneath 'workspaces' like config, website, etc.
  • "Remove duplicate permissions for role 'roleB' in 'acl_Expression' workspace." - i know i am picky but 'acl_Expression' is name of the node - remove acl_ prefix to get correct workspace name.
Comment by Roman Kovařík [ 29/Jan/14 ]

BootstrapSingleResource should not be deprecated.

Generated at Mon Feb 12 04:06:28 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.