- Check Copyright --> 2014

- In CopyPropertyTask first constructor: Use the workspace passed in argument instead of the 'hard coded' one

- In MovePropertyTask, CopyPropertyTask
- I would also change the logic in the doExecute (check if the source props exist, check if the dest do not exist or can be override, and then do the operation)

In MovePropertyTaskTest, CopyPropertyTaskTest (Add test)
- Would be cool if you could add a test with override = false and a already existing props...

In RenameNodeTaskTest, RenamePropertyTaskTest
- Add tests (one with override = true, one with false, one with non existing source)

In MovePropertyTask, CopyPropertyTask
- I would also change the logic in the doExecute (check if the source props exist, check if the dest do not exist or can be override, and then do the operation)
Shouldn't the task rather fail in case that property doesn't exist (And we should use PropertyExistsDelegateTask / NodeExistsDelegateTask) instead?
|