[MAGNOLIA-5628] Remove obsolete dms.jsp Created: 16/Jan/14  Updated: 18/Mar/14  Resolved: 21/Jan/14

Status: Closed
Project: Magnolia
Component/s: updatemechanism
Affects Version/s: 5.2.1
Fix Version/s: 5.2.2

Type: Task Priority: Minor
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: maintenance
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-5709 Backport info.magnolia.module.delta.R... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Epic Link: migration_to_5.2.2

 Description   

Leftover after update from Magnolia 4.5. Although it's harmless issue, we have to keep migration test green:
http://hudson.magnolia-cms.com/view/X/job/magnolia-4-5-migration_with_integration_tests/ws/magnolia-migration-integration/diff-reports/server.html



 Comments   
Comment by Magnolia International [ 17/Jan/14 ]

Review notes:

  • The task is called and described "remove obsolete files", but it does not remove files.
  • The task is added to the 5.0 delta ? So this will never be executed for anyone updating their 5.0+ instance ? (even though they might still have those nodes, if they've already updated to anything released until now)
  • If this is removing obsolete stuff in the md5-check nodes - why isn't it actually checking if the corresponding files are indeed gone, and vice-versa ?
  • maybe: if we had some update task in the past that removed a file on the filesystem (I presume that's the case here?) that task should also take care of removing its corresponding entry in the md5-check nodes ?
Comment by Roman Kovařík [ 21/Jan/14 ]
  • The task is called and described "remove obsolete files", but it does not remove files.
    Added task which removes also a md5 nodes and files.
  • The task is added to the 5.0 delta ? So this will never be executed for anyone updating their 5.0+ instance ? (even though they might still have those nodes, if they've already updated to anything released until now)
    You're right, moved to delta 5.2.2
  • If this is removing obsolete stuff in the md5-check nodes - why isn't it actually checking if the corresponding files are indeed gone, and vice-versa ? maybe: if we had some update task in the past that removed a file on the filesystem (I presume that's the case here?) that task should also take care of removing its corresponding entry in the md5-check nodes
    I think this is not the case here, dms.jsp is only leftover from Magnolia 4.4/5 and was actually also on filesystem after update to Magnolia 5.
Generated at Mon Feb 12 04:06:54 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.