[MAGNOLIA-5641] Implement generics support in info.magnolia.voting (so voters can be typed) Created: 24/Jan/14 Updated: 28/Feb/14 Resolved: 26/Feb/14 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | None |
| Fix Version/s: | 5.3 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Magnolia International | Assignee: | Philip Mundt |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: | |
| Epic Link: | Personalisation |
| Sprint: | 5.3 Preparation 2 |
| Description |
|
Currently, the Voter interface works with Object. Some voters are fine that way, because they're working with different types of input. Some, on the other hand, expect a specific type of input object, and have to cast. It'd be helpful for those voters to be able to implements Voter<Foo> and avoid casting altogether. It'd make code and tests clearer too. |
| Comments |
| Comment by Magnolia International [ 24/Jan/14 ] |
|
Done in the feature/p13n branch, as it was needed for other p13n voter related work. Some more improvements to voters are expected. |
| Comment by Philip Mundt [ 26/Feb/14 ] |
|
Some changes to the javadoc got lost during the merge. Please fix. |