[MAGNOLIA-5711] Dot before and after selector causes NPE Created: 10/Mar/14 Updated: 18/Mar/14 Resolved: 14/Mar/14 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | 4.5.17 |
| Fix Version/s: | 4.5.18 |
| Type: | Bug | Priority: | Blocker |
| Reporter: | Edgar Vonk | Assignee: | Jaroslav Simak |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | maintenance | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Mac OS X, Chrome, Magnolia 4.5.17 |
||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
Magnolia 4.5.17 seems to break the shop product detail page of the Magnolia Shop Module. Shop product detail URLs such as in our Worldsteel Shop: http://localhost:8080/magnoliaAuthor/internet/publications/bookshop/product-details.~Map-of-China-steel-mills~PRODUCT~Map1~.html now result in a 404 error page (nothing in the logs). Backporting to Magnolia 4.5.16 solves the issue. It must be something in the Magnolia 4.5.17 changelog that causes this. Could you please look into this? Of course we do want to upgrade to 4.5.17 (and future releases). In any case I don't think the product detail URLs are particularly nice. '~' symbols in URLs are not common practice and are in fact not officially supported (but do work I guess..): From the RFC 1738 specification:
The most SEO and user friendly solution would be something like: but that would be a bit harder to implement I guess. And this would only work when shop product names are unique (which they are not currently). Not a bad thing I think. Alternatively the unique product UUID could be used. PS: I have not tested it on a clean Magnolia 4.5.17 with Shop Module and demo project yet. |
| Comments |
| Comment by Edgar Vonk [ 12/Mar/14 ] |
|
I have now tested this on a clean Magnolia 4.5.17 install with Magnolia Module Shop 1.1.4 and Magnolia Module OCM 1.0.2 and I can confirm the issue. Therefore I think the issue is really a blocker? Nobody who uses the Magnolia Shop Module can upgrade to Magnolia 4.5.17 at the moment. I will raise the priority and see what happens. |
| Comment by Jaroslav Simak [ 13/Mar/14 ] |
|
Same issue exists in latest 5.x branch. |