[MAGNOLIA-5750] Cargo: replace uses of zipUrlInstaller by artifactInstaller Created: 22/Apr/14  Updated: 19/Dec/16  Resolved: 04/May/15

Status: Closed
Project: Magnolia
Component/s: integration tests
Affects Version/s: None
Fix Version/s: 4.5.25, 5.3.9

Type: Task Priority: Neutral
Reporter: Magnolia International Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: testing
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Cloners
is cloned by MGNLEE-388 Cargo: replace uses of zipUrlInstalle... Closed
dependency
Template:
Acceptance criteria:
Empty
Task DoR:
Empty

 Description   

In the configuration of the cargo plugin, we can
1) Replace this:

<zipUrlInstaller>
  <url>http://dist.codehaus.org/jetty/jetty-6.1.22/jetty-6.1.22.zip</url>
  <installDir>${basedir}/tmp/cargo-install</installDir>
</zipUrlInstaller>

by this:

<artifactInstaller>
  <groupId>org.mortbay.jetty</groupId>
  <artifactId>jetty</artifactId>
  <classifier>bundle</classifier>
  <version>6.1.26</version>
</artifactInstaller>

This might require some research to find the correct artifacts, but it seems recent containers have an artifact available.
If we need to keep the different profiles (our int tests can (in theory) run on different containers), will require introducing a couple of properties or rearranging the configuration to some extent. (perhaps move part of the cargo config in the profiles entirely, which means some could still be using a url)

2) Replace or remove this: <home>${basedir}/tmp/cargo-home</home>. Defaults to ${project.build.directory}/cargo/configurations/${containerId}, which is just as well.

Benefits:

  • job really cleans itself entirely, no tmp folder lying around in the workspace (by default, the container is downloaded under target/, so we originally configured cargo this way to avoid re-downloading the container for every build)
  • the container distribution (zip) is cached the local maven repository, so we won't download it every time either.


 Comments   
Comment by Magnolia International [ 04/May/15 ]

Fixed on magnolia-bundle-4.5.x, magnolia-bundle-5.2.x, magnolia-bundle-5.3.x and master branches.

Cargo is now configured in <pluginManagement>, container-selection profiles partially reconfigure it, and only the <executions> binding are left in the <plugins> section.

As a consequence, each container/profile is free to decide whether they want to use zipUrlInstaller or artifactInstaller and we don't have to create a ton of properties.

Generated at Mon Feb 12 04:08:02 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.