[MAGNOLIA-5761] IsModuleInstalledOrRegistered: find a more reliable way to check if a module is already installed Created: 02/May/14  Updated: 19/May/22  Resolved: 19/May/22

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 4.5.19, 5.2.4
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Federico Grilli Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLOBS-13 Observation module deletes existing l... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

The IsModuleInstalledOrRegistered task currently checks if the module node is present or if there's a module entry in the install context. However, module A can bootstrap module B node, thus fooling the task into believing that B is installed while it is actually not. Typical example for this is the observation module. Observation module is optional and no longer bundled by default and one often has ended up in a situation where some module bootstraps /module/observation/config/listenerConfigurations/foo thus implicitly creating a /module/observation node even if the module is not actually installed. Other modules subsequently using IsModuleInstalledOrRegistered(..) will thus act as if the module is installed even though it is not.
One way to make the check more reliable is to look for the presence of the version property under the module node. It's far from being foolproof but could be an improvement over the current situation.



 Comments   
Comment by Roman Kovařík [ 19/May/22 ]

Hello,

This ticket is now marked as closed due to one of the following reasons:

  • A long period of inactivity
  • Uses an old or Beta version of an application, module, or framework that we no longer support
  • The issue is no longer reproducible or has been fixed in later versions

If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you.

Thank you,
The Magnolia Team

Generated at Mon Feb 12 04:08:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.