[MAGNOLIA-5827] getBoolean and getDate in PropertyUtil should be nullsafe like the other methods Created: 07/Jul/14  Updated: 02/Jun/15  Resolved: 26/May/15

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 5.2.5
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Frank Sommer Assignee: Ilgun Ilgun
Resolution: Fixed Votes: 0
Labels: quickwin
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

info.magnolia.jcr.util.PropertyUtil#getBoolean is not null safe. Method throws a NullPointerException, if the given node is null. getString and getLong methods checks the node before against null.



 Comments   
Comment by Daniel Lipp [ 09/Nov/14 ]

Whole util should be made consistent: looks like not only #getBoolean but also #getDate doesn't have that null-check.

Comment by Ilgun Ilgun [ 26/May/15 ]

Reverted all the non-related changes, should be good to go now.

Generated at Mon Feb 12 04:08:45 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.