Rendering improvements (MAGNOLIA-5895)

[MAGNOLIA-5839] Revise implementation of Rendering Listeners Created: 21/Jul/14  Updated: 24/Jun/15  Resolved: 05/Jan/15

Status: Closed
Project: Magnolia
Component/s: rendering
Affects Version/s: None
Fix Version/s: 5.4

Type: Sub-task Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MAGNOLIA-5999 Rendering listeners: performance impr... Closed
dependency
is depended upon by MAGNOLIA-5837 Revise implementation of Direct Area ... Closed
is depended upon by MAGNOLIA-5838 Revision of output provider and wrapper Closed
relation
is related to MAGNOLIA-6039 Implement FragmentDefinition on Rende... Closed
Template:
Release notes required:
Yes
Date of First Response:

 Description   

Current rendering listeners are quite limited as they are not able influence rendering engine in any way. We need to be able return some sort of status from listeners so rendering engine could react on that.

  1. Make info.magnolia.rendering.context.RenderingListener deprecated in favour of AbstractRenderingListener:
    Nonparametric constructor by be able instantiate by N2B.
    String AbstractRenderingListener.init() method (any logic from RederingListener s constructors should go there).
    String AbstractRenderingListener.before().
    String AbstractRenderingListener.after().
  2. The configuration of listeners should be moved from info.magnolia.rendering.renderer.registry.RendererRegistry to RenderingEngine as it doesn't belong there.
  3. Handle results of rendering listeners in RenderingEngine/RenderingFilter


 Comments   
Comment by Roman Kovařík [ 21/Aug/14 ]

Resolved on branch feature/snippet-caching.

Comment by Roman Kovařík [ 10/Nov/14 ]

Squashed on the parent ticket.

Comment by Magnolia International [ 29/Dec/14 ]

While looking at info.magnolia.rendering.renderer.registry.RendererRegistry, I see the List<Class<RenderingListener>> listeners is still there but unused. You probably just forgot about it ?

Similar, in info.magnolia.rendering.renderer.registry.ConfiguredRendererManager, I see a bunch of constants that now seem unused. Since they were public, they should probably be deprecated instead of just removed (? your call, I'm not sure what they were used for)

There are maybe other such details to cleanup ?

Comment by Roman Kovařík [ 05/Jan/15 ]

Changes related to this ticket: https://git.magnolia-cms.com/gitweb/?p=magnolia_main.git;a=commitdiff;h=1946233c18ece59846403dc9ba3f0a65dc300479
Others: https://git.magnolia-cms.com/gitweb/?p=magnolia_main.git;a=commitdiff;h=748b40ab7e132960a402ec3bdce0e87ca18d256b

Generated at Mon Feb 12 04:08:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.