[MAGNOLIA-584] BarNew doesn't check for admin mode Created: 24/Oct/05  Updated: 23/Jan/13  Resolved: 25/Oct/05

Status: Closed
Project: Magnolia
Component/s: admininterface
Affects Version/s: 2.1 Final
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Martin Wehner Assignee: Philipp Bärfuss
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File barnew-admin.patch    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

BarNew doesn't check if the instance it's rendering on is in admin mode (like the other controls do). This leads to the newbar displaying on the publish instance under some circumstances.



 Comments   
Comment by Martin Wehner [ 24/Oct/05 ]

Patch that adds the check for admin mode to BarNew.java

Comment by Philipp Bracher [ 24/Oct/05 ]

Perhaps you forgot the adminOnly tag?

<cms:adminOnly>
<div style="clear:both;">
<cms:newBar contentNodeCollectionName="mainColumnParagraphs"
paragraph="samplesTextImage,samplesDownload,samplesLink,samplesTable"/>
</div>
</cms:adminOnly>

If not, let me know.

Comment by Philipp Bracher [ 25/Oct/05 ]

use adminOnly tag

Comment by Martin Wehner [ 25/Oct/05 ]

We don't use the taglib, but our own inline controls (which extend the stock Magnolia ones) from Java components. The point about the adminOnly tag is taken, but I don't get why BarMain and BarEdit check for admin mode themselfs and BarNew doesn't. That seems inconsistent to me. Anyway, not a big problem - We put a work around in our code.

Comment by Philipp Bracher [ 25/Oct/05 ]

thanks for pointing out the inconsistency I wil remove it the one or the other way.

I think the main, edit and new bar should be available in the public instance too. Having in mind wiki and guest-book solutions I think we must allow the developer to control the behavior.

Generated at Mon Feb 12 03:18:53 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.