[MAGNOLIA-5890] Node2BeanTransformer: setProperty can throw Node2BeanException, and expose method to handle setProperty exceptions Created: 18/Aug/14 Updated: 04/Mar/19 |
|
| Status: | Open |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Magnolia International | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | n2b, quickwin | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: | |
| Story Points: | 5 |
| Description |
|
With commit #36e6c2a7, we introduced a private handleSetPropertyException method. We could make this method protected, thus overridable for custom transformers, but that would only make sense if those methods can throw Node2BeanException (for now it only throws RepositoryException, because that's what the signature of Node2BeanTransformer#setProperty lets us throw). Validate: what are the impacts, what happens when a transformer throws a Node2BeanException there and then. (since this is in a catch(Exception) block, it might not be any useful, it might interrupt the "flow" and no other properties are set anyway ?) |
| Comments |
| Comment by Jan Haderka [ 29/Jul/15 ] |
|
commit # ? |
| Comment by Magnolia International [ 29/Jul/15 ] |
|
edited |