[MAGNOLIA-5955] RedirectClientCallback may duplicate the parameter in url and double the '?' Created: 16/Oct/14 Updated: 19/May/22 Resolved: 19/May/22 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | security |
| Affects Version/s: | 5.3.4 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Eric Hechinger | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: |
| Description |
|
When the session has expired, the user has to be redirected to login page.
Issue is that RedirectClientCallback duplicate the parameter:
if (StringUtils.isNotBlank(parameterString)) {
// cut off trailing "&"
url += StringUtils.contains(url, "?") ? "" : "?" + StringUtils.substringBeforeLast(parameterString, "&");
target += StringUtils.contains(target, "?") ? "" : "?" + StringUtils.substringBeforeLast(parameterString, "&");
}
For example: unfortunately the url created is the following: http://localhost:8080/cma-extranet-project-webapp/cma-project/cma-document.html?locale=en&uuid=e6b4459f-b10a-448b-ac5d-aed8d5b2bb73 but I've got http://localhost:8080/cma-extranet-project-webapp/cma-project/cma-document.html?locale=en&uuid=e6b4459f-b10a-448b-ac5d-aed8d5b2bb73?locale=en |
| Comments |
| Comment by Philip Mundt [ 16/Oct/14 ] |
|
Add patch MAGNOLIA-5955.patch |
| Comment by Roman Kovařík [ 19/May/22 ] |
|
Hello, This ticket is now marked as closed due to one of the following reasons:
If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you. Thank you, |