[MAGNOLIA-6033] Upgrade info.magnolia.templating.elements.ComponentElement functions to not return null but default values. Created: 08/Jan/15  Updated: 19/May/22  Resolved: 19/May/22

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 5.3.6
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Evzen Fochr Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

functions resolveMoveable, resolveWritable, resolveDeletable sometimes not returns default value but returns null. f.e. resolveDeletable could be updated to

private Boolean resolveDeletable(final OperationPermissionDefinition permissions, User user) {

        Boolean deletable = this.deletable != null ? this.deletable : componentDefinition != null && componentDefinition.getDeletable() != null ? componentDefinition.getDeletable() : null;
        // try to get the permissions from template availability
        if (permissions != null && !permissions.canDelete(user)) {
            return false;
        }

        if (deletable != null) {
            return deletable;
        }

        // true by default
        return true;
    }


 Comments   
Comment by Roman Kovařík [ 19/May/22 ]

Hello,

This ticket is now marked as closed due to one of the following reasons:

  • A long period of inactivity
  • Uses an old or Beta version of an application, module, or framework that we no longer support
  • The issue is no longer reproducible or has been fixed in later versions

If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you.

Thank you,
The Magnolia Team

Generated at Mon Feb 12 04:10:40 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.