[MAGNOLIA-6038] LinkUtil doesn't use defaultExtension Created: 08/Jan/15  Updated: 12/Jan/15  Resolved: 12/Jan/15

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 5.3.6
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Evzen Fochr Assignee: Mikaël Geljić
Resolution: Not an issue Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLUI-3216 Removing hardcoded extension for inte... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

LinkUtil doesn't use defaultExtension but hardcoded one from /magnolia-ui-form/src/main/resources/VAADIN/js/magnolialink/plugin.js

1. use defaultExtension for internal magnolia links
2. nodeData and extension should not be dependent on each other in UUID_PATTERN
3. use extension from UUID_PATTERN to override defaultExtension value for iternal magnolia links



 Comments   
Comment by Evzen Fochr [ 08/Jan/15 ]

tests neened

Comment by Evzen Fochr [ 09/Jan/15 ]

point 2 cannot be done in minor release because it changes number of pattern fragments, f.e. extension only matcher.group(8) to matcher.group(9). This pattern is public and if somebody is using it we broke his/her implementation.

Comment by Mikaël Geljić [ 12/Jan/15 ]

This is not an issue; see Link#getExtension().
You will notice that in the event of a "null" extension, the fallback to ServerConfiguration's defaultExtension is handled there already.

Therefore there is nothing to fix in LinkUtil.

Closing as Not-an-issue; nonetheless I will integrate the additional test-case.

Generated at Mon Feb 12 04:10:43 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.