[MAGNOLIA-6041] Create a method on UserManager returning all users of a given group including the users for transitive groups Created: 12/Jan/15  Updated: 24/Mar/16  Resolved: 19/Jan/15

Status: Closed
Project: Magnolia
Component/s: security
Affects Version/s: None
Fix Version/s: 5.3.7

Type: Improvement Priority: Neutral
Reporter: Christoph Meier Assignee: Christoph Meier
Resolution: Fixed Votes: 0
Labels: security
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MAGNOLIA-6615 UserManager#getUsersWithGroup(groupNa... Closed
dependency
is depended upon by MGNLUI-3315 Speed up messaging with many users in... Closed
is depended upon by MGNLUI-3316 Speed up LocalTaskDispatcherManager Closed
relation
is related to MAGNOLIA-6010 Add possibility to retrieve all users... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Date of First Response:

 Description   

The requirement has raised by MGNLUI-3315.
On UserManager , there is already
public Collection<String> getUsersWithGroup(String groupName); but that onre returns "only" the users which belong to exactly that group;
but we also need the users belonging to groups which belong to the given group = transitive groups.



 Comments   
Comment by Christoph Meier [ 14/Jan/15 ]

Fix committed onto branch "MAGNOLIA-6041" (see http://goo.gl/YyNGCu)

Comment by Espen Jervidalo [ 15/Jan/15 ]

As discussed:

  • I would consider using the SQL2 based getGroupsWithGroup for retrieving the transitive groups.
  • rename parameter 'includeUsersFromTransitiveGroups' to 'transitive' and explain what it does in javadoc

Not related to your changes, but some javadoc of the difference between groupManager.getAllGroups and .getGroupsWithGroup would be nice.

Generated at Mon Feb 12 04:10:45 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.