[MAGNOLIA-6047] Provide possibility to use RenderExceptionHandler without RenderingContext Created: 23/Jan/15 Updated: 16/Feb/15 Resolved: 04/Feb/15 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | rendering |
| Affects Version/s: | None |
| Fix Version/s: | 5.4 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Roman Kovařík | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | m3 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Epic Link: | DPC | ||||||||
| Description |
|
We currently have RenderExceptionHandler which is able to render errors (e.g. from Freemarker). It's not possible to use it outside of rendering since informations from RenderingContext are not relevant. Add method void handleException(RenderException renderException, Appendable out); |
| Comments |
| Comment by Magnolia International [ 29/Jan/15 ] |
|
| Comment by Roman Kovařík [ 02/Feb/15 ] |
|
The old constructor removed.
We need to know from the AggregationState if we are in preview mode to see how a page would look like on a public instance.
I want to keep the old method signature if possible. The aggregationState was originally retrieved from MgnlContext.
Exception handling at least simplified.
The old one still provides the current template name. Both delegates to info.magnolia.rendering.engine.ModeDependentRenderExceptionHandler#handleException Tests cleaned up. |
| Comment by Magnolia International [ 03/Feb/15 ] |
|
Sorry, gotta reopen for something that didn't occur to me earlier. We need to document how the 2 methods are different (it was more obvious when there was only one); why there are 2, in which case one would use which, etc. Regarding AggregationState - I finally agree with not adding it as a param to the methods. Rationale:
|