[MAGNOLIA-6091] Use injection in ConfiguredTemplateDefinition Created: 18/Feb/15 Updated: 18/Mar/15 Resolved: 27/Feb/15 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | rendering |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Espen Jervidalo | Assignee: | Espen Jervidalo |
| Resolution: | Not an issue | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
Using injection allows us to use the ConfiguredTemplateDefinition without having to inherit it just for defining a custom template availability. |
| Comments |
| Comment by Magnolia International [ 18/Feb/15 ] |
|
So your fix actually doesn't use injection, since it uses Components.getComponent. I'm also concerned that we'd need to do this sort of patch of anything that currently uses injection and gets proxied. I have a vague memory of facing something similar with the i18n mechanism we implemented in 5.2, which also uses proxies. Maybe there's a hint there about we could potentially "customize" the way the proxy creates the instance.
That said, I made a bunch of assumptions to understand your use-case, so let's check this out |
| Comment by Espen Jervidalo [ 27/Feb/15 ] |
|
the problem I tried to solve with this was fixed in bca57ac3ffed21a1c10c03a5941b30000eab3aaf of new site module. Closing this ticket a obsolete. |